Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error with "Invalid attempt to destructure non-iterable instance" #3252

Closed
wants to merge 8 commits into from
Closed

Fix error with "Invalid attempt to destructure non-iterable instance" #3252

wants to merge 8 commits into from

Conversation

xakep139
Copy link
Contributor

@xakep139 xakep139 commented Dec 5, 2018

Fix #2755

ReiiYuki
ReiiYuki suggested changes Dec 15, 2018
View reviewed changes
src/Select.js Show resolved Hide resolved
src/Select.js Show resolved Hide resolved
@xakep139
Copy link
Contributor Author

@ReiiYuki, I've implemented your suggestions

@gwyneplaine gwyneplaine mentioned this pull request Dec 27, 2018
Closed
@ReiiYuki
Copy link

I'm wondering why does the test fail???

@xakep139
Copy link
Contributor Author

I suppose failed tests were fixed in #3253

@xakep139 xakep139 closed this Dec 27, 2018
@xakep139 xakep139 deleted the patch-1 branch December 27, 2018 16:55
@xakep139
Copy link
Contributor Author

@ReiiYuki, I've created #3302 from scratch as replacement of this PR

@ReiiYuki
Copy link

@xakep139 Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReiiYuki ReiiYuki ReiiYuki requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xakep139 @ReiiYuki