Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-describedby attribute #3273

Closed

Conversation

sreahard
Copy link

@sreahard sreahard commented Dec 13, 2018

Added aria-describedby attribute support in order to link elements to the react-select select input such as help text and validation errors.

The prop was added with pr #1571 but somehow got removed in the current version. This adds it back.

Per the upgrading docs:

aria-describedby | unchanged

Fixes #1570

@bdrazen
Copy link

bdrazen commented Mar 11, 2019

Still not able to set aria-describedby. 🙁 Has no one else looked into this?

Edit: My workaround was to define a custom component:

import Select, { components } from 'react-select';

<Select
  ...
  components={{ Input: MyInput }}
/>

const MyInput = (props) => <components.Input {...props} aria-describedby={someId} />

@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome and removed ready-for-review labels May 26, 2020
@bladey bladey added category/accessibility Issues or PRs related to accessibility enhancement labels Jun 4, 2020
@bladey
Copy link
Contributor

bladey commented Jun 11, 2020

Hi @sreahard, thanks for your contribution, I've since taken your changes and updated them to support master and the new test framework, see PR #4082.

@bladey bladey closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/accessibility Issues or PRs related to accessibility pr/needs-review PRs that need to be reviewed to determine outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support for aria-describedby attribute
4 participants