Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix null reference when using opt-groups in Creatable #3338

Closed
wants to merge 2 commits into from

Conversation

JoshMcCullough
Copy link
Contributor

@JoshMcCullough
Copy link
Contributor Author

FYI I don't think these CI failures are due to my changes.

@razh
Copy link

razh commented Jan 10, 2019

@JoshMcCullough

It's failing because of lint errors/warnings:

$ eslint .

/root/project/repo/src/Creatable.js
  38:7  error  'compareOption' is assigned a value but never used  no-unused-vars

/root/project/repo/src/Select.js
  1004:1   warning  Trailing spaces not allowed                         no-trailing-spaces
  1467:13  warning  'isFocused' is already declared in the upper scope  no-shadow

 3 problems (1 error, 2 warnings)
  0 errors, 1 warning potentially fixable with the `--fix` option.

https://circleci.com/gh/JedWatson/react-select/1881

@JoshMcCullough
Copy link
Contributor Author

Yes I know, but check my changes -- unrelated to those files, those lint issues were already present before this PR, so should be fixed in master.

@JoshMcCullough
Copy link
Contributor Author

Fixed one lint issue here and opened a PR for the others: #3343

@bladey bladey added pr/bug-fix PRs that are specifically addressing a bug pr/needs-review PRs that need to be reviewed to determine outcome labels Jun 4, 2020
@ebonow
Copy link
Collaborator

ebonow commented Jan 16, 2021

Greetings @JoshMcCullough and thank you for the submission. Also apologies for the delay in a response. The community and its contributors deserve better and I apologize that this has remained open so long without reply.

I wanted to test that this issue still exists and it appears that it has already been resolved. Here is a fork of the example posted in #3056 with the only change being an update from react-select v2.0.0 to v2.4.4

demo: codesandbox

Since this issue no longer appears to be present, I thought it appropriate to close this PR but also to thank you for offering your time and contributing code in an effort to help fellow developers experiencing this same issue. The team and the community are appreciative for any contributions to making react-select better.

If you feel that this was closed prematurely or are able to reproduce errors, please feel free to provide an example and we can revisit and reopen this PR.

@ebonow ebonow closed this Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/bug-fix PRs that are specifically addressing a bug pr/needs-review PRs that need to be reviewed to determine outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants