Styled options #380
Merged
Styled options #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the default optionRenderer, specifying `style` or `className` means the style/class gets applied at the same level as `.Select-option` Closes JedWatson#44
Previous commit was just for the menu, this adds the same styling info to the option once it's selected
This is similar to `className` and `style` properties of the option, in that `title` can also be set from the option itself Fixes JedWatson#273
|
Two more issues, and one PR, closed 😀 I think this is a good change - there are two ways to achieve it, but this is much lighter weight if it's all you want to customise. Let's go with it. |
|
it would be good to add this to the documentation. |
|
@bruderstein i ran into the same problem. I need an optional field for each option field. Beside value and label i need for example an optionalData Object. Is there an approach or rather a best practice for my problem? #2807 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #290, adding
classNameandstylesupport to the options objects.Obviously, you can now do this with the renderers or custom components, however, I wanted to have the option that the default components support it. I'm entirely agnostic about this - on the one hand it would be better to keep stuff like this up to custom renderers, on the other hand, it'd be nice that the defaults do some basics like this.
I've added
titlesupport too, to address #273Just to reiterate, I really am agnostic about this - this was a quick fix that if thrown away, really doesn't matter. I'm just trying to clear some older issues. Either, this is merged and #290 and #273 can be closed, or this is not merged, and #290 and #273 can be closed because it can be done via the custom component props. - Either way, 2 issues down 😄