Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow type imports #5769

Closed
wants to merge 2 commits into from
Closed

Allow type imports #5769

wants to merge 2 commits into from

Conversation

xec
Copy link

@xec xec commented Oct 9, 2023

I'm working on a typescript react component library that wraps and restyles react-select including types, and in an effort to make that work we currently have the following type import;

import type SelectClass from 'react-select/dist/declarations/src/Select'

exports field in package.json was introduced in #5559 which breaks this since nothing can be imported from react-select/dist/declarations/... any longer :/

Adding an export rule for declaration types in the package fixes this issue.

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

🦋 Changeset detected

Latest commit: 6b55791

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xec
Copy link
Author

xec commented Oct 9, 2023

duplicate of #5762

@xec xec closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant