Fix pop-value being sent for undefined values.

[leonaves]

Because of this array access:

react-select/packages/react-select/src/Select.tsx

Line 1091 in 884f1c4

const lastSelectedValue = selectValue[selectValue.length - 1];

removedValue could technically be undefined. This happens when the select box is empty and a user hits backspace. It can cause runtime errors in the consuming libraries if the options are objects rather than primitives. This stops those actions being sent.

(The other option would be to update the typing in the below part of the code to mark removedValue as optional, forcing consumers to protect against potential undefined values, but I believe this makes more sense, as we are not removing anything if the set of values is already empty, so sending a pop-value action doesn't really make sense):

react-select/packages/react-select/src/types.ts

Lines 138 to 142 in edf5265

	export interface PopValueActionMeta<Option> extends ActionMetaBase<Option> {
	action: 'pop-value';
	removedValue: Option;
	name?: string;
	}

[changeset-bot]

🦋 Changeset detected

Latest commit: 5c9fe3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
react-select	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[leonaves]

@lukebennett88 @emmatown @Methuselah96 I know this library isn't super actively maintained at the moment, but this is a tiny change with test coverage so I'd love a real quick look and a patch release! Would be really appreciated! 🙏

[Methuselah96]

Hmm, this could technically be considered a breaking change, but this is probably our best option. I'll approve and merge if no one objects in the next 24 hours.

[leonaves]

@Methuselah96 Yeah I considered that, but as the exact shape of these events isn't actually documented anywhere (as far as I can see) other than the exported types, and the exported types actually declare that removedValue will never be undefined, I'd say it's fine to call it a patch.

[Methuselah96]

Unfortunately react-select is popular enough that Hyrum's Law is in full effect. If it turns out people were depending on this, and there's on other sufficient solution, I'd be quick to revert it.

[leonaves]

I'll approve and merge if no one objects in the next 24 hours.

👀 😄

[lights-a5]

Commenting here that this change broke my tests for some reason this morning. I haven't been able to delve too deeply into it or to find out what I'm doing that is breaking it. I can confirm that it was working on version 5.8.0 and not 5.8.1.

[kibertoad]

@lights-a5 Can you check if your tests are correct in this case? maybe they were checking that the wrong behaviour is wrong and actually need to be adjusted

[lights-a5]

The problem is me it turns out. The require for Select had a d3 in its name and my jest config has a moduleNameMapper mapped from d3 to a d3 library. The only change from you was the slug changed in the dist that included d3 in it.

Just bad regex on my part. Sorry for the alarm!