Fixes #50 - No Support for xsd:import in Schema Handling #55
Conversation
There was a problem hiding this comment.
Question about this change: my original intent with the XML interfaces is so that I could swap out XML parsing implementations as needed without disturbing the rest of Gepsio. In other words, instead of Gepsio calling XML methods directly, it would call an interface implementation without needing to know the details of what XML implementation was being used. This design allowed, for example, for Gepsio to switch from the old .NET Framework System.Xml implementation to the newer System.Xml.Linq implementation without having to go through Gepsio to find all of the XML implementation details scattered throughout. This design, logically, gives Gepsio a layered design that looks something like this:
.NET runtime -> XML handling -> Gepsio
With that in place, it seems like the XML handling should be able to live "in isolation", which it should be able to work without knowing anything about Gepsio. At first glance, the usage of LinkbaseDocumentCollection within ISchemaSet implies that the XML implementation must now know about Gepsio, which breaks that layering design of ".NET -> XML -> Gepsio".
There are two possibilities:
- This can be refactored so that the XML implementation remains ignorant of the "higher level" Gepsio, or
- the ".NET -> XML -> Gepsio" logical layering is naive and not actually feasible
What are your thoughts there?
There was a problem hiding this comment.
You're absolutely right, I should keep the LinkbaseDocumentCollection within XbrlSchema !
I will amend this PR.
Note that SystemXml implementation fails because Attribute.Node property is not implemented.
|
Hi @JeffFerguson, Are you still waiting on something from me since my last commit? |
xsd:import is handled by XmlSchema but this PR takes care of considering linkbases of imported schemas.