Add support for Askey STI6130 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffLIrion
reviewed
Oct 30, 2024
JeffLIrion
reviewed
Oct 30, 2024
Co-authored-by: Jeff Irion <JeffLIrion@users.noreply.github.com> update documentation for product_id more lint issues.
prabhjotsbhatia-ca
force-pushed
the
patch-1
branch
from
d84789d
to
1ac448f
Compare
|
@JeffLIrion thank you for your comments! I was able to fix linting and added the product_id to the documentation. Additionally, I found an existing bug in the documentation for the _parse_device_properties function here: (The "Returns" section header is missing in the code and consequently all the documentation is showing up incorrectly under Parameters) Would you like me to fix that as a part of this PR or would you like me to open a subsequent PR after this current one is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Askey STI6130 is a widely used box sold under various brands including Bell Streamer in Canada, Google ADT-3 Developer box, Dynalink etc. and is based on the Amlogic S905Y2 board, which is the same board as the widely hyped Walmart Onn android tv box.
I don't have an Onn box to test, but it is likely this same scheme would work on that as well.
Tested:
All unit tests pass.
I had to add a new key to detect the product ID.