Fixed secure hooking of tooltip #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hooks the tooltip securely. This has side-effects in the tooltip code, which are handled a bit abruptly. If additional information about a spell is needed, the addon should get its own GameTooltip and extract that information from it.
Added some tonumber conversion, probably caused by tooltip not containing the expected text.
|
Note that it currently works, but has certain issues - my Priests Flash Heal reports two different "heailing til oom" values (37.50k vs 1.35k). It seems one calculation only gets the +healing value and the other gets the base value as well? |
|
Using your branch my tooltip doesn't properly show the average heal/dmg for some reason. My heals show things like 8 average heal. Not sure why yours still at least somewhat properly calculates healing done, but I assume it's missing data that was being extracted from the tooltip before that it no longer can get. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has side effects, but should have been done earlier.
Unsure how Theorycraft originally worked, but the whole way of using the GameTooltip to both extract information and put in the new one at the same time is not very good.
If extraction of information is needed, do that on a separate, addon-specific GameTooltip frame.