Update UUID vendor #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears github.com/satori/go.uuid is functionally deprecated, and has been superceded by github.com/gofrs/uuid. - satori/go.uuid#84 - satori/go.uuid#90 This came to my attention because of un-tagged changes to satori/go.uuid that changed the signature of uuid.NewV4() from a single return val to two, resulting in: $ go get github.com/Jeffail/leaps/cmd/... warning: ignoring symlink /Users/ia/go/src/github.com/Jeffail/leaps/cmd/leaps/www warning: ignoring symlink /Users/ia/go/src/github.com/Jeffail/leaps/cmd/leaps/www # github.com/Jeffail/leaps/lib/util go/src/github.com/Jeffail/leaps/lib/util/uuid_gen.go:51:19: multiple-value uuid.NewV4() in single-value context Of course running 'dep ensure' fixed this issue, but it seems like this project should use the 'longer fork' of this dependency in any case. This change does NOT address the 'what to do with the error value' question; it just ignores the possible error.
Intended as a way to 'handle the error without handling the error'.
|
Thanks @whilei! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears github.com/satori/go.uuid is functionally deprecated,
and has been superceded by github.com/gofrs/uuid.
This came to my attention because of un-tagged changes to
satori/go.uuid that changed the signature of uuid.NewV4()
from a single return val to two, resulting in:
Of course running 'dep ensure' fixed this issue, but
it seems like this project should use the 'longer fork'
of this dependency in any case.