Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minuit integration #13

Merged
merged 9 commits into from
Oct 1, 2016
Merged

Minuit integration #13

merged 9 commits into from
Oct 1, 2016

Conversation

pelssers
Copy link
Collaborator

This implements integration of the Minuit minimizer via the iminuit package.
Currently 'bestfit_minuit' provides the same functionality as the 'bestfit_scipy' function ('bestfit_scipy' is still the default).
Minuit can be used by setting the 'bestfit_routine' parameter in 'plot_likelihood_ratio' or 'one_parameter_interval' to 'bestfit_minuit'.

This addresses/solves issue #10

@JelleAalbers
Copy link
Owner

Solid work Bart! I made some small additions:

  • Made iminuit the default bestfit routine, if minuit is installed. Otherwise switch to scipy, but berate the user for not installing iminuit :-) I've had some serious headaches with the scipy minimizers in blueice previously, and again a few days ago on a (degenerate) test problem (something with the "dumb" spatial likelihood I think).
  • Set defaults to produce no extra output, since bestfit is called iteratively from the higher-level functions in blueice.inference. Do you think a common quiet=True/False switch for both minimizers is a good idea? Since the extra output is very useful for a big final fit and debugging.

@JelleAalbers JelleAalbers merged commit d98ffe5 into master Oct 1, 2016
@JelleAalbers JelleAalbers deleted the iminuit branch October 2, 2016 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants