Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Knut's work on SR1 into master #23

Merged
merged 13 commits into from
Mar 23, 2018
Merged

Conversation

JelleAalbers
Copy link
Owner

@JelleAalbers JelleAalbers commented Mar 23, 2018

This merges the work of @kdund's development branch for XENON1T SR1 into master:

  • Ability to set an 'efficiency' shape parameter, which reduces the expected event rate for all sources which have apply_efficiency = True in their configuration.
  • split_results function for LogLikelihoodSum, which takes a parameter list (e.g. output of a best fit) and splits it into parameter dictionaries appropriate for the individual likelihoods
  • Ability to set different livetime_days in LogLikelihoodSum, probably for the purpose of run combinations.

I fixed a small bug in the last feature (the changed livetimes were not actually propagated)

@JelleAalbers JelleAalbers requested a review from kdund March 23, 2018 12:31
Copy link
Collaborator

@kdund kdund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelleAalbers JelleAalbers merged commit bdb24e5 into master Mar 23, 2018
@JelleAalbers JelleAalbers deleted the merge_knut_sr1_dev branch March 23, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants