Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify travis, scipy instead of iminuit as default #24

Merged
merged 4 commits into from
Mar 23, 2018

Conversation

JelleAalbers
Copy link
Owner

This wil:

  • Set scipy minimizers to be the default, even if you have iminuit installed. In my code and what I've seen from @kdund we use scipy minimizers exclusively; apparently the problems we once had with these are now resolved and/or we had other problems with iminuit. Or maybe it's just setting the Powell method that did the magic? In any case, if nobody is using iminuit it probably shouldn't be the default. @pelssers, since you implemented the iminuit minimizers, would you agree?
  • Simplify the travis build instructions. Since wheels exist we do not need anaconda to install binaries, so the travis file can just be a few lines.
  • Also test python 3.6 on Travis.

@pelssers
Copy link
Collaborator

I agree with using scipy as default, it is the more robust option and well tested in the xenon analysis.

@JelleAalbers
Copy link
Owner Author

Ok, thanks!

@JelleAalbers JelleAalbers merged commit 04f4efa into master Mar 23, 2018
@JelleAalbers JelleAalbers deleted the simplify_travis branch March 23, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants