Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounds to Minuit optimizer #26

Merged
merged 4 commits into from
Feb 6, 2019
Merged

Add bounds to Minuit optimizer #26

merged 4 commits into from
Feb 6, 2019

Conversation

pelssers
Copy link
Collaborator

@pelssers pelssers commented Feb 6, 2019

Passes bounds for each parameter to the Minuit optimizer by adding them to the iminuit dictionary.

pelssers and others added 4 commits February 6, 2019 15:13
In case we start using errors in the future. At the moment errors are just discarded. Closes #25
Copy link
Owner

@JelleAalbers JelleAalbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bart! This will ensure bestfit_minuit works again, and probably make it work more stable. I've added one more argument that may help get more meaningful errors out of minuit (although we currently discard those errors, so there is not yet much point).

@JelleAalbers JelleAalbers merged commit 8160137 into master Feb 6, 2019
@JelleAalbers JelleAalbers deleted the iminuit_bounds branch February 6, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants