Corrections and improvements

Cargo.toml

@@ -45,7 +45,7 @@ features = ["full"]
 rustdoc-args = ["--cfg", "docsrs"]
 
 [lints.rust]
-unexpected_cfgs = { level = "warn", check-cfg = ['cfg(ci)', 'cfg(nightly)', 'cfg(msrv)'] }
+unexpected_cfgs = { level = "warn", check-cfg = ["cfg(ci)", "cfg(msrv)", "cfg(nightly)"] }
 
 [features]
 default = ["std"]

examples/deny_missing_docs.rs

@@ -1,7 +1,7 @@
 //! Some docs
 
-#![allow(dead_code)]
 #![deny(missing_docs)]
+#![allow(dead_code)] // for illustration purposes
 
 use derive_more::{
     Add, AddAssign, Constructor, Deref, DerefMut, Display, From, FromStr, Index,
@@ -34,7 +34,6 @@ pub struct MyBoxedInt(Box<i32>);
 pub struct MyVec(Vec<i32>);
 
 /// Some docs
-#[allow(dead_code)]
 #[derive(Clone, Copy, TryInto)]
 #[derive(IsVariant)]
 enum MixedInts {

impl/Cargo.toml

@@ -44,7 +44,7 @@ features = ["full"]
 rustdoc-args = ["--cfg", "docsrs"]
 
 [lints.rust]
-unexpected_cfgs = { level = "warn", check-cfg = ['cfg(ci)', 'cfg(nighthly)'] }
+unexpected_cfgs = { level = "warn", check-cfg = ["cfg(ci)", "cfg(nighthly)"] }
 
 [features]
 default = []

impl/src/into.rs

@@ -178,8 +178,8 @@ impl<'a> Expansion<'a> {
                 let tys: Vec<_> = fields_tys.validate_type(out_ty)?.collect();
 
                 Ok(quote! {
-                    #[automatically_derived]
                     #[allow(clippy::unused_unit)]
+                    #[automatically_derived]
                     impl #impl_gens derive_more::core::convert::From<#r #lf #m #input_ident #ty_gens>
                      for ( #( #r #lf #m #tys ),* ) #where_clause
                     {

impl/src/utils.rs

@@ -1,7 +1,6 @@
 #![cfg_attr(
     not(all(feature = "add", feature = "mul")),
-    allow(dead_code),
-    allow(unused_mut)
+    allow(dead_code, unused_mut)
 )]
 
 use proc_macro2::TokenStream;

tests/add.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 use derive_more::Add;
 

tests/add_assign.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 use derive_more::AddAssign;
 

tests/as_mut.rs

@@ -1,5 +1,6 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code, clippy::unnecessary_mut_passed)]
+#![allow(clippy::unnecessary_mut_passed)] // testing correct signatures rather than actual code
+#![allow(dead_code)] // some code is tested for type checking only
 
 #[cfg(not(feature = "std"))]
 extern crate alloc;

tests/as_ref.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 #[cfg(not(feature = "std"))]
 extern crate alloc;

tests/boats_display_derive.rs

@@ -35,7 +35,7 @@ fn tuple_struct() {
     assert_eq!(s, "Error code: 2");
 }
 
-#[allow(clippy::enum_variant_names)]
+#[allow(clippy::enum_variant_names)] // because of the original source
 #[derive(Display)]
 enum EnumError {
     #[display("Error code: {}", code)]

tests/constructor.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 use derive_more::Constructor;
 

tests/debug.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 #[cfg(not(feature = "std"))]
 extern crate alloc;

tests/deref.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code, unused_imports)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 #[cfg(not(feature = "std"))]
 extern crate alloc;

tests/deref_mut.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code, unused_imports)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 #[cfg(not(feature = "std"))]
 extern crate alloc;

tests/display.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code, unused_imports)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 #[cfg(not(feature = "std"))]
 extern crate alloc;

tests/error/derives_for_enums_with_source.rs

@@ -1,4 +1,5 @@
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
+
 use super::*;
 
 derive_display!(TestErr);

tests/error/derives_for_generic_enums_with_source.rs

@@ -1,4 +1,5 @@
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
+
 use super::*;
 
 derive_display!(TestErr, T, E);

tests/error/derives_for_generic_structs_with_source.rs

@@ -1,4 +1,5 @@
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
+
 use super::*;
 
 #[test]

tests/error/derives_for_structs_with_source.rs

@@ -1,4 +1,5 @@
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
+
 use super::*;
 
 #[test]

tests/error/nightly/derives_for_enums_with_backtrace.rs

@@ -1,7 +1,6 @@
-#![allow(dead_code)]
-// Allow redundant closures in tests, because we use them to create backtraces with different
-// addresses.
-#![allow(clippy::redundant_closure, clippy::redundant_closure_call)]
+// For creating backtraces with different addresses in tests.
+#![allow(clippy::redundant_closure, clippy::redundant_closure_call)] // for testing
+#![allow(dead_code)] // some code is tested for type checking only
 
 use core::error::{request_ref, request_value};
 

tests/error/nightly/derives_for_generic_enums_with_backtrace.rs

@@ -1,7 +1,6 @@
-#![allow(dead_code)]
-// Allow redundant closures in tests, because we use them to create backtraces with different
-// addresses.
-#![allow(clippy::redundant_closure, clippy::redundant_closure_call)]
+// For creating backtraces with different addresses in tests.
+#![allow(clippy::redundant_closure, clippy::redundant_closure_call)] // for testing
+#![allow(dead_code)] // some code is tested for type checking only
 
 use core::error::{request_ref, request_value};
 

tests/error/nightly/derives_for_generic_structs_with_backtrace.rs

@@ -1,7 +1,6 @@
-#![allow(dead_code)]
-// Allow redundant closures in tests, because we use them to create backtraces with different
-// addresses.
-#![allow(clippy::redundant_closure, clippy::redundant_closure_call)]
+// For creating backtraces with different addresses in tests.
+#![allow(clippy::redundant_closure, clippy::redundant_closure_call)] // for testing
+#![allow(dead_code)] // some code is tested for type checking only
 
 use core::error::{request_ref, request_value};
 

tests/error/nightly/derives_for_structs_with_backtrace.rs

@@ -1,7 +1,6 @@
-#![allow(dead_code)]
-// Allow redundant closures in tests, because we use them to create backtraces with different
-// addresses.
-#![allow(clippy::redundant_closure, clippy::redundant_closure_call)]
+// For creating backtraces with different addresses in tests.
+#![allow(clippy::redundant_closure, clippy::redundant_closure_call)] // for testing
+#![allow(dead_code)] // some code is tested for type checking only
 
 use core::error::{request_ref, request_value};
 

tests/from.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 #[cfg(not(feature = "std"))]
 extern crate alloc;

tests/from_str.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 #[cfg(not(feature = "std"))]
 extern crate alloc;

tests/generics.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code, non_camel_case_types)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 use derive_more::{
     Add, AddAssign, Constructor, Deref, DerefMut, Display, Error, From, FromStr, Index,

tests/index.rs

@@ -1,5 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(dead_code, unused_imports)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 #[cfg(not(feature = "std"))]
 extern crate alloc;

tests/index_mut.rs

@@ -1,4 +1,4 @@
-#![allow(dead_code, unused_imports)]
+#![allow(dead_code)] // some code is tested for type checking only
 
 use derive_more::IndexMut;