Re-export errors from ops and unexport ops module #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also moves errors that are specific to add to a separate file. Otherwise rustdoc would show them to be included for the features: "(add or not) and add", which is obviously equivalent to add but reads super weird.
tyranron
previously approved these changes
Jul 27, 2023
There was a problem hiding this comment.
@JelteF I've moved add module back to ops as ops::add one. This seems more logical to me since add uses types from ops, and in std they're all united under ops module too.
Please, take a look and merge it, if it's OK for you.
Sadly this makes the feature list for WrongVariantError and BinaryError in the docs still look bad. Can you revert that part of the change? The feature list looks like this then: |
tyranron
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #274
Synopsis
Re-export error types from the ops module from the root of the crate. And
unexport the ops module itself.
This also moves errors that are specific to add to a separate file.
Otherwise rustdoc would show them to be included for the features:
"(add or not) and add", which is obviously equivalent to add but reads
super weird.
Checklist
Documentation is updated (if required)Tests are added/updated (if required)CHANGELOG entry is added (if required)