-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Display docs to accurately describe bounds behaviour #297
Conversation
@tyranron This is shown in the docs example and this test, just not documented correctly. This was the case at least as far back as v0.99.0, so I'm not sure what to do about the changelog, since there's no actual change being made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MegaBluejay please, trace back the commit/PR where this was changed, and mention it in the CHANGELOG.
Ah, sorry, didn't understand you correctly. Then, please, add the CHANGELOG entry to the "Fixed" section, explaining the wrong docs were fixed. Do you see a need in more tests to control this behavior? |
I added a few for the case with no inferred |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MegaBluejay good job! 🍻
Resolves #281
Synopsis
The docs for the
Display
derive state that explicitly specified bounds replace the auto-inferred ones, when this is actually not the case.There's also some outdated information about what's allowed in
#[display(bound(...)]
arguments, and incorrect example generated where clauses.Solution
Update the docs
Checklist