fix: EXPOSED-651 Try to close connection in ThreadLocalTransactionManager#connectionLazy if setup fails #2320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: Try to close connection in
ThreadLocalTransactionManager#connectionLazy
if setup failsDetailed description:
ThreadLocalTransactionManager#connectionLazy
now catches exceptions and attempts to close the database connection in case of an exception.Database
, Exposed tries to perform some initial setup before using the connection in aTransaction
. If this setup fails, the connection is not closed (neither immediately nor when closing the transaction, because the connection is not stored inside the transaction due tolazy
semantics), which in turn leads to connection leak.try-catch
block, which catches all exceptions and tries to close the connection before rethrowing.Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
java.sql.Driver
to reproduceRelated Issues
EXPOSED-651