Compose as LifecycleOwner
#1198
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Copyright 2024 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package androidx.compose.ui.platform | ||
|
|
||
| import androidx.compose.runtime.staticCompositionLocalOf | ||
| import androidx.lifecycle.LifecycleOwner | ||
|
|
||
| /** | ||
| * The CompositionLocal containing the current [LifecycleOwner]. | ||
| */ | ||
| actual val LocalLifecycleOwner = staticCompositionLocalOf<LifecycleOwner> { | ||
| noLocalProvidedFor("LocalLifecycleOwner") | ||
| } | ||
|
|
||
| @Suppress("SameParameterValue") | ||
| private fun noLocalProvidedFor(name: String): Nothing { | ||
| error("CompositionLocal $name not present") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /* | ||
| * Copyright 2024 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package androidx.compose.ui.window | ||
|
|
||
| import kotlinx.cinterop.ObjCAction | ||
| import platform.Foundation.NSNotificationCenter | ||
| import platform.Foundation.NSSelectorFromString | ||
| import platform.UIKit.UIApplication | ||
| import platform.UIKit.UIApplicationDidEnterBackgroundNotification | ||
| import platform.UIKit.UIApplicationState | ||
| import platform.UIKit.UIApplicationWillEnterForegroundNotification | ||
| import platform.darwin.NSObject | ||
|
|
||
| internal class ApplicationStateListener( | ||
| /** | ||
| * Callback which will be called with `true` when the app becomes active, and `false` when the app goes background | ||
| */ | ||
| private val callback: (Boolean) -> Unit | ||
| ) : NSObject() { | ||
| init { | ||
| val notificationCenter = NSNotificationCenter.defaultCenter | ||
|
|
||
| notificationCenter.addObserver( | ||
| this, | ||
| NSSelectorFromString(::applicationWillEnterForeground.name), | ||
| UIApplicationWillEnterForegroundNotification, | ||
| null | ||
| ) | ||
|
|
||
| notificationCenter.addObserver( | ||
| this, | ||
| NSSelectorFromString(::applicationDidEnterBackground.name), | ||
| UIApplicationDidEnterBackgroundNotification, | ||
| null | ||
| ) | ||
| } | ||
|
|
||
| @ObjCAction | ||
| fun applicationWillEnterForeground() { | ||
| callback(true) | ||
| } | ||
|
|
||
| @ObjCAction | ||
| fun applicationDidEnterBackground() { | ||
| callback(false) | ||
| } | ||
|
|
||
| /** | ||
| * Deregister from [NSNotificationCenter] | ||
| */ | ||
| fun dispose() { | ||
| val notificationCenter = NSNotificationCenter.defaultCenter | ||
|
|
||
| notificationCenter.removeObserver(this, UIApplicationWillEnterForegroundNotification, null) | ||
| notificationCenter.removeObserver(this, UIApplicationDidEnterBackgroundNotification, null) | ||
| } | ||
|
|
||
| companion object { | ||
| val isApplicationActive: Boolean | ||
| get() = UIApplication.sharedApplication.applicationState != UIApplicationState.UIApplicationStateBackground | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we add a new dependency, this change requires 2 approves, please ask someone else to review this commit (about adding dependency).
It looks fine for me, because we either will release a stable version of
lifecycle, or we just depend on stable API of it right now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eymar, no need to review the whole PR, only this commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having these dependencies added, we can't avoid publishing lifecycle libraries (there was an idea that maybe we don't need to publish lifecyclce right now - #1204 (comment)). User projects won't work with this ui library if we don't publish lifecycle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you talk about my comment:
I meant that "if don't need it right now". But we definitely need it for the 1.6.10 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even dev builds won't work untill lifecycle is published if this PR is merged before that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Then let's wait until we publish