Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEA-358562 Add Gradle Daemon toolchain support on IDE #2861

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vmadalin
Copy link
Contributor

Context

The Daemon toolchain was introduced in Gradle 8.8 and the motivation behind it and other technical details can be found on the public spec document. This PR adds the IDE support allowing users to easily modify the project Daemon criteria directly from the Gradle Settings UI, without to manually require to do it via CLI. The implementation follows the agreed details on spec document and UI/UX document

Tasks

Tests

Integration Tests

Demo

Daemon.toolchain.IDE.support.mov

@vmadalin vmadalin force-pushed the feature/add-daemon-toolchain-support branch from d2cea21 to 8aa741b Compare October 15, 2024 13:14
@vmadalin vmadalin marked this pull request as ready for review October 15, 2024 13:14
@vmadalin vmadalin changed the title Add Gradle Daemon toolchain support on IDE IDEA-358562 Add Gradle Daemon toolchain support on IDE Oct 21, 2024
@HackerMadCat HackerMadCat self-assigned this Oct 24, 2024
@vmadalin vmadalin force-pushed the feature/add-daemon-toolchain-support branch from 8aa741b to ee8fe38 Compare October 25, 2024 14:32
@HackerMadCat
Copy link
Member

Could you please specify the gradle-daemon-jvm.properties file in the GradleAutoImportAware.GradlePropertiesCollector? With it, the auto-sync started tracking changes in this file and will suggest a sync project if they exist.

@vmadalin vmadalin force-pushed the feature/add-daemon-toolchain-support branch from 4a4bc71 to 94eb4d1 Compare November 6, 2024 13:02
@vmadalin
Copy link
Contributor Author

vmadalin commented Nov 6, 2024

Could you please specify the gradle-daemon-jvm.properties file in the GradleAutoImportAware.GradlePropertiesCollector? With it, the auto-sync started tracking changes in this file and will suggest a sync project if they exist.

Absolutely, this will be done separately as part of already created ticket https://github.com/users/vmadalin/projects/3/views/1

I also improved the experience about updating Daemon Jvm criteria from settings which will use the Project SDK to execute the updateDaemonJvm task representing this one the latest successfully java home used to sync project. All of this is aligned with having a unidirectional flow between Gradle JDK and Project SDK being the following: Gradle JDK -> Project SDK. At the same time, after gradle/gradle#30956 the overall experience will be even much better when invalid criteria is defined since Gradle will skip validation

Gradle.settings.demo.mov

@vmadalin vmadalin force-pushed the feature/add-daemon-toolchain-support branch from 94eb4d1 to 44b0bba Compare November 6, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants