-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDEA-358562 Add Gradle Daemon toolchain support on IDE #2861
base: master
Are you sure you want to change the base?
IDEA-358562 Add Gradle Daemon toolchain support on IDE #2861
Conversation
d2cea21
to
8aa741b
Compare
8aa741b
to
ee8fe38
Compare
...system-impl/src/com/intellij/openapi/externalSystem/service/project/manage/SdkDataService.kt
Outdated
Show resolved
Hide resolved
...com/intellij/openapi/externalSystem/service/settings/AbstractExternalSystemConfigurable.java
Outdated
Show resolved
Hide resolved
...c/org/jetbrains/plugins/gradle/service/settings/IdeaGradleProjectSettingsControlBuilder.java
Show resolved
Hide resolved
plugins/gradle/src/org/jetbrains/plugins/gradle/service/settings/GradleDaemonJvmCriteriaView.kt
Show resolved
Hide resolved
plugins/gradle/src/org/jetbrains/plugins/gradle/statistics/GradleSettingsCollector.kt
Show resolved
Hide resolved
plugins/gradle/src/org/jetbrains/plugins/gradle/util/GradleJvmResolutionUtil.kt
Show resolved
Hide resolved
plugins/gradle/src/org/jetbrains/plugins/gradle/service/settings/GradleDaemonJvmCriteriaView.kt
Outdated
Show resolved
Hide resolved
plugins/gradle/src/org/jetbrains/plugins/gradle/service/settings/GradleDaemonJvmCriteriaView.kt
Outdated
Show resolved
Hide resolved
plugins/gradle/src/org/jetbrains/plugins/gradle/service/settings/GradleDaemonJvmCriteriaView.kt
Outdated
Show resolved
Hide resolved
Could you please specify the |
4a4bc71
to
94eb4d1
Compare
Absolutely, this will be done separately as part of already created ticket https://github.com/users/vmadalin/projects/3/views/1 I also improved the experience about updating Gradle.settings.demo.mov |
94eb4d1
to
44b0bba
Compare
Context
The
Daemon toolchain
was introduced in Gradle 8.8 and the motivation behind it and other technical details can be found on the public spec document. This PR adds the IDE support allowing users to easily modify the project Daemon criteria directly from the Gradle Settings UI, without to manually require to do it via CLI. The implementation follows the agreed details on spec document and UI/UX documentTasks
Tests
Integration Tests
Demo
Daemon.toolchain.IDE.support.mov