[kotlin][debugger] Don't throw when exception occurred in the completable future #2871
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes when computing classes with inlined code, an ObjectCollectedException could be thrown in on of the futures. This resulted in failure of `CompleatableFuture.allOf(*futures)`. Because of this, smart stepping and breakpoints in inline functions sometimes didn't work, which was easy to observe when debugging on Android.
| @@ -610,9 +610,9 @@ class KotlinPositionManager(private val debugProcess: DebugProcess) : MultiReque | |||
| private fun getClassesWithInlinedCode(candidatesWithInline: List<String>, line: Int): List<ReferenceType> { | |||
| val candidatesWithInlineInternalNames = candidatesWithInline.map { it.fqnToInternalName() } | |||
| val futures = debugProcess.virtualMachineProxy.allClasses().map { type -> | |||
| hasInlinedLinesToAsync(type, line, candidatesWithInlineInternalNames).thenApply { hasInlinedLines -> | |||
| @@ -610,9 +610,9 @@ class KotlinPositionManager(private val debugProcess: DebugProcess) : MultiReque | |||
| private fun getClassesWithInlinedCode(candidatesWithInline: List<String>, line: Int): List<ReferenceType> { | |||
| val candidatesWithInlineInternalNames = candidatesWithInline.map { it.fqnToInternalName() } | |||
| val futures = debugProcess.virtualMachineProxy.allClasses().map { type -> | |||
There was a problem hiding this comment.
Suggested change
| val futures = debugProcess.virtualMachineProxy.allClasses().map { type -> | |
| val futures = debugProcess.virtualMachineProxy.allClasses().map { type -> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when computing classes with inlined code, an ObjectCollectedException could be thrown in on of the futures. This resulted in failure of
CompleatableFuture.allOf(*futures). Because of this, smart stepping and breakpoints in inline functions sometimes didn't work, which was easy to observe when debugging on Android.@zuevmaxim