code review

JetBrains · Oct 13, 2024 · d4f9a6e · d4f9a6e
1 parent fda0f69
commit d4f9a6e
Show file tree

Hide file tree

Showing 3 changed files with 239 additions and 281 deletions.
diff --git a/...kotlin/org/jetbrains/intellij/platform/gradle/artifacts/transform/ExtractorTransformer.kt b/...kotlin/org/jetbrains/intellij/platform/gradle/artifacts/transform/ExtractorTransformer.kt
@@ -130,7 +130,7 @@ abstract class ExtractorTransformer @Inject constructor(
 
     /**
      * Pre-create Ivy XML files so that later this directory can be used as an Ivy repository without having to discover
-     * modules & plugins each time the build is run.
+     * modules and plugins each time the build is run.
      */
     private fun createIvyXmls(platformPath: Path) {
         val isIde = platformPath.listDirectoryEntries().map { it.name }.containsAll(
@@ -150,12 +150,12 @@ abstract class ExtractorTransformer @Inject constructor(
         val pluginManager = IdePluginManager.createManager(createTempDirectory())
         val bundledPlugins = platformPath.getBundledPlugins(pluginManager)
 
-        for (plugin in bundledPlugins.values) {
+        bundledPlugins.values.forEach { plugin ->
             val pluginId = plugin.pluginId
             val pluginVersion = plugin.pluginVersion
             val pluginPath = plugin.originalFile
             if (null == pluginId || null == pluginVersion || null == pluginPath) {
-                continue
+                return@forEach
             }
 
             val group = Constants.Configurations.Dependencies.BUNDLED_PLUGIN_GROUP