Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap plugin problems when resolving plugin dependencies #1124

Merged
merged 13 commits into from
Aug 5, 2024

Conversation

novotnyr
Copy link
Collaborator

@novotnyr novotnyr commented Jul 19, 2024

Plugin dependencies that are resolved as standard Platform plugins might contain problems.

Some plugins, including those from JetBrains, may have problems leading to error-level plugin problems. In such cases, these plugins are not resolved as dependencies, which can result in unexpected reports of missing dependencies, even when they are actually available.

  • Introduce a new PluginInfo type: DependencyPluginInfo that wraps any other plugin info. This indicates a plugin that will be resolved as a dependency.
  • Introduce a repository that delegates to other repositories and treats the results as DependencyPluginInfo instances.
  • Make corresponding PluginInfo instances aware of the IdePlugin via explicit interface when appropriate
  • AbstractPluginDetailsProvider allows to customize the creation of the plugin on the subclass-level.
  • DefaultPluginDetailsProvider and SizeLimitedPluginDetailsCache are dependency-aware. They are using different strategy when resolving plugin as a dependency. More relaxed plugin problem rules are put in place.

@novotnyr novotnyr merged commit e47fb0f into master Aug 5, 2024
4 checks passed
@novotnyr novotnyr deleted the problem-remapping-in-dependent-plugins branch August 5, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants