TC actions name as composite id namespace/id
#1159
Conversation
...ons/src/main/kotlin/com/jetbrains/plugin/structure/teamcity/action/TeamCityActionProblems.kt
Outdated
Show resolved
Hide resolved
| const val NAME = "id" | ||
| const val DESCRIPTION = "the second part of the composite `${ActionName.NAME}` field" | ||
| const val MIN_LENGTH = 5 | ||
| const val MAX_LENGTH = 30 |
There was a problem hiding this comment.
I was thinking of raising the max length for the action id, maybe to 50 symbols. 30 seems a bit too short for the action name, but should be ok for the namespace name. Do you have any constraints on plugin id length on the Marketplace side?
There was a problem hiding this comment.
The limit is 190 characters (for TC Actions it will be the limit for the composite id namespace/name).
There was a problem hiding this comment.
Let's discuss it separately since there are no actual users right now. We will be able to extend this limit anytime in the future.
...actions/src/main/kotlin/com/jetbrains/plugin/structure/teamcity/action/TeamCityActionSpec.kt
Outdated
Show resolved
Hide resolved
...s/src/main/kotlin/com/jetbrains/plugin/structure/teamcity/action/TeamCityActionDescriptor.kt
Outdated
Show resolved
Hide resolved
...actions/src/main/kotlin/com/jetbrains/plugin/structure/teamcity/action/TeamCityActionSpec.kt
Outdated
Show resolved
Hide resolved
...teamcity-actions/src/main/kotlin/com/jetbrains/plugin/structure/teamcity/action/Validator.kt
Outdated
Show resolved
Hide resolved
...teamcity-actions/src/main/kotlin/com/jetbrains/plugin/structure/teamcity/action/Validator.kt
Outdated
Show resolved
Hide resolved
|
I've implemented the suggested fixes in my fork – boris-yakhno@eeffeaf |
* Composite name format validation * Name validation changes * Tests
|
Added a commit with fixes to the PR, as suggested by @kesarevs |
No description provided.