Fix remembers painter twice and break the cache #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
devkanro
commented
Feb 17, 2024
devkanro
commented
- Move the InDebugMode property to foundation module.
- Rename the utils in foundation to util
- Fix remembers painter twice to break the cache, see the comments below.
devkanro
commented
Feb 17, 2024
| @@ -166,7 +166,7 @@ public class ResourcePainterProvider( | |||
| loadSvgPainter(inputStream, scope) | |||
| } | |||
| }, | |||
| rememberAction = { remember(url, scope.density) { it } }, | |||
| paintAction = { it }, | |||
There was a problem hiding this comment.
We should not remember painter here, because we have already the cache here.
Before:
After:
It only happened with first default selected icon button
devkanro
commented
Feb 17, 2024
| @@ -205,7 +205,7 @@ public class ResourcePainterProvider( | |||
| loadingAction = { resourceUrl -> | |||
| resourceUrl.openStream().use { loadXmlImageVector(InputSource(it), scope) } | |||
| }, | |||
| rememberAction = { rememberVectorPainter(it) }, | |||
| paintAction = { rememberVectorPainter(it) }, | |||
There was a problem hiding this comment.
We can still remember the vector because vector self is a key.
devkanro
commented
Feb 17, 2024
| ) | ||
|
|
||
| @Composable | ||
| private fun <T> tryLoadingResource( | ||
| url: URL, | ||
| loadingAction: (URL) -> T, | ||
| rememberAction: @Composable (T) -> Painter, | ||
| paintAction: @Composable (T) -> Painter, |
There was a problem hiding this comment.
So I rename the rememberAction to paintAction, it more seems like a action to convert T to a painter
devkanro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.