Replace icon paths with keys #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rock3r
commented
Jul 8, 2024
Comment on lines
+24
to
+34
| java { | ||
| toolchain { | ||
| vendor = JvmVendorSpec.JETBRAINS | ||
| } | ||
| } | ||
|
|
||
| kotlin { | ||
| jvmToolchain { | ||
| vendor = JvmVendorSpec.JETBRAINS | ||
| } | ||
| } |
There was a problem hiding this comment.
This was previously done in the jewel plugin, but it's not anymore as it's not the recommended approach anymore for IDE-bound code. However, we still need it for the standalone sample, so we can ensure it is run on the JBR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all direct usages of icon paths and painter providers in the components' styling with icon keys. There is no visual or behaviour difference (except now icon mapping works in IJ 242 and the dropdown component looks correct under New UI).