Rename palette entry grey -> gray #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name was changed in 242 to reflect the fact that everything else is named in en-US, and for consistency with the Int UI specs. This change aligns us to that, leaving a deprecated grey accessor in ThemeColorPalette for backwards compat. The lookup function also accepts both spellings for the time being. This also bumps the theme generator to target IJP 242. Note that some of these changes will not be ported to earlier releases — only the ThemeColorPalette property name changes and lookup behaviour — since in 233 and 241 the keys are still named in en-GB in the theme json
rock3r
added
consistency
jakub-senohrabek-jb
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name was changed in 242 to reflect the fact that everything else is named in en-US, and for consistency with the Int UI specs. This change aligns us to that, leaving a deprecated grey accessor in ThemeColorPalette for backwards compat. The lookup function also accepts both spellings for the time being.
This also bumps the theme generator to target IJP 242.
Note that some of these changes will not be ported to earlier releases — only the ThemeColorPalette property name changes and lookup behaviour — since in 233 and 241 the keys are still named in en-GB in the theme json.
Most relevant changes:
ThemeColorPalette.ktandIntUiThemeDescriptorReader.kt; the rest is just running a rename refactor.