Lower target JDK for 242 #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had set 21 as that was the JDK that the IJP 242 runs on, but that was causing issues in some other places. Since the target JDK is a _minimum_ level, code targeting 17 also works fine in 21. Because of this, we have no reason not to lower it back to 17.
rock3r
force-pushed
the
lower-target-jdk-for-242
branch
from
edad657
to
09494e9
Compare
|
Smoke tested locally, shipping without review (yolo) as I need this urgently, and it's a small change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had set 21 as that was the JDK that the IJP 242 runs on, but that was causing issues in some other places. Since the target JDK is a minimum level, code targeting 17 also works fine in 21. Because of this, we have no reason not to lower it back to 17.