Add selectable and toggleable Icon(Action)Button #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces two variants for `IconButton` and `IconActionButton`: * `SelectableIcon(Action)Button` * `ToggleableIcon(Action)Button` What they do should be self-evident. Other changes include adding the ability to provide `PainterHint`s to `IconActionButton`s, adding a standalone demo for the new icon buttons, separating and cleaning out states and styling helpers. Note: the main difference between an `IconButton` and its equivalent `IconActionButton` is that the latter is built upon the former, and handles automatically: * Tooltips (if defined) * Stroke modifiers (for selectable and toggleable) * Icon loading
rock3r
added
new component
hamen
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces two variants for
IconButtonandIconActionButton:SelectableIcon(Action)ButtonToggleableIcon(Action)ButtonWhat they do should be self-evident.
Other changes include adding the ability to provide
PainterHints toIconActionButtons, adding a standalone demo for the new icon buttons, separating and cleaning out states and styling helpers.Important
This PR makes
ToggleableComponentStatenot extendSelectableComponentStateanymore. It should never have been extending it to begin with, but we did it to save some time in the past. Semantically, it is not correct, so this PR undoes that change and updates the Checkbox accordingly.Note: the main difference between an
IconButtonand its equivalentIconActionButtonis that the latter is built upon the former, and handles automatically: