Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up work on scrollbars #521

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

hamen
Copy link
Collaborator

@hamen hamen commented Aug 7, 2024

  • Improved management for ScrollbarStyle.dark() and ScrollbarStyle.light()
  • Improved naming for methods like windowsAndLinuxDark()
  • Introduction of tabStrip* ScrollbarStyle for Tabs
  • Clean up of the showcase sample code for TextAread and TextFields

Recording2024-08-07104611-ezgif com-video-to-gif-converter

#	samples/standalone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/view/component/Scrollbars.kt
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen hamen added the consistency Our UI presentation is not consistent with IJ label Aug 7, 2024
@hamen hamen requested a review from rock3r August 7, 2024 08:48
@hamen hamen self-assigned this Aug 7, 2024
Copy link
Collaborator

@rock3r rock3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Only a few unnecessary or bad formatting changes to revert

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@rock3r rock3r enabled auto-merge (squash) August 7, 2024 10:47
@rock3r rock3r merged commit 9a24684 into main Aug 7, 2024
4 checks passed
@rock3r rock3r deleted the im-108-add-scrollbars-to-textareas branch August 7, 2024 10:51
This was referenced Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency Our UI presentation is not consistent with IJ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants