Use icon keys everywhere #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamen
approved these changes
Sep 4, 2024
rock3r
added a commit
that referenced
this pull request
Sep 5, 2024
In this case, they were used in the Menus API. Not sure why find usages did not show these when I did the work for #576...
rock3r
added a commit
that referenced
this pull request
Sep 5, 2024
In this case, they were used in the Menus API. Not sure why find usages did not show these when I did the work for #576...
rock3r
added a commit
that referenced
this pull request
Sep 5, 2024
* Remove one more usage of resource-based Icon APIs In this case, they were used in the Menus API. Not sure why find usages did not show these when I did the work for #576... * Update readme, fleshing out icon loading in particular * Deprecate PlatformIcon — not needed anymore IconKey now carries the class information with itself, so no need for the composable anymore, whose job was to provide a default class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the last usages of the old, deprecated
PainterProvider- andString-basedIconAPIs to theIconKey-based ones. It then marks the deprecated methods as scheduled for removal before 1.0.Closes #433