Remove underline on unhovered Links #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rock3r
added a commit
that referenced
this pull request
Sep 23, 2024
In #598, for some reason a drawStyle = Stroke(2f) was added to the bridge focused link style, causing rendering of focused links to look weird in the bridge. This fixes the issue, and also makes sure the pressed links are also underlined, matching Swing's behaviour.
Merged
rock3r
added a commit
that referenced
this pull request
Sep 23, 2024
In #598, for some reason a drawStyle = Stroke(2f) was added to the bridge focused link style, causing rendering of focused links to look weird in the bridge. This fixes the issue, and also makes sure the pressed links are also underlined, matching Swing's behaviour.
rock3r
pushed a commit
that referenced
this pull request
Sep 24, 2024
Co-authored-by: Francisco Noriega <francisco.noriega@airbnb.com>
rock3r
added a commit
that referenced
this pull request
Sep 24, 2024
In #598, for some reason a drawStyle = Stroke(2f) was added to the bridge focused link style, causing rendering of focused links to look weird in the bridge. This fixes the issue, and also makes sure the pressed links are also underlined, matching Swing's behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IJ's default markdown does not show underline on links when they are not hovered, it only shows them on hovered. This matches that.
Since we currently don't support the more advance rounded border span for Focused state, I also included the underline for Focus.
Screen.Recording.2024-09-17.at.10.39.04.AM_H.265.mp4
Screen.Recording.2024-09-17.at.10.43.54.AM_H.265.mp4
cc: @rock3r