Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ComboBox component #601

Closed
wants to merge 49 commits into from
Closed

New ComboBox component #601

wants to merge 49 commits into from

Commits on Oct 1, 2024

  1. integrate ComboBox in Standalone 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    bdca109 View commit details
    Browse the repository at this point in the history

  2. add ComboBoxes to SwingComparisonTabPanel 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a2b1c7e View commit details
    Browse the repository at this point in the history

  3. fix text color in ComboBox 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1aec042 View commit details
    Browse the repository at this point in the history

  4. add a bit of space below combobox in IDE example 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5c15c0c View commit details
    Browse the repository at this point in the history

  5. tune ComboBox popup padding 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f116f7a View commit details
    Browse the repository at this point in the history

  6. fix ComboBox field background color 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    43a67ae View commit details
    Browse the repository at this point in the history

  7. extract textStyle in ComboBox 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e82331c View commit details
    Browse the repository at this point in the history

  8. update API files 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9f9cff5 View commit details
    Browse the repository at this point in the history

  9. make the formatter happy 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    93c0a5d View commit details
    Browse the repository at this point in the history

  10. fix ComboBox border 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    88a422c View commit details
    Browse the repository at this point in the history

  11. tune ComboBox focus 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    dc845eb View commit details
    Browse the repository at this point in the history

  12. Revert "tune ComboBox focus" 

    This reverts commit f336503.
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8bd8689 View commit details
    Browse the repository at this point in the history

  13. iterate on focus 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1b2fdc9 View commit details
    Browse the repository at this point in the history

  14. reformat 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7e9fb0d View commit details
    Browse the repository at this point in the history

  15. remove cursorBrush style 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a93d8d3 View commit details
    Browse the repository at this point in the history

  16. add isEditable flag to ComboBox 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0793ba9 View commit details
    Browse the repository at this point in the history

  17. make the formatter happy

    @hamen
    morgillo authored and hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7f99dba View commit details
    Browse the repository at this point in the history

  18. tune ComboBox menu horizontal padding 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    12c6165 View commit details
    Browse the repository at this point in the history

  19. remove offset from Standalone style 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    56c7510 View commit details
    Browse the repository at this point in the history

  20. fix a couple of paddings in the menu 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a7dd1a9 View commit details
    Browse the repository at this point in the history

  21. make linter and formatter happy 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d1c6eae View commit details
    Browse the repository at this point in the history

  22. make the formatter happy

    @hamen
    morgillo authored and hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d3fe048 View commit details
    Browse the repository at this point in the history

  23. add not-editable ComboBox to Standalone 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d196e2a View commit details
    Browse the repository at this point in the history

  24. fix focus on not-editable ComboBox 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4521fc3 View commit details
    Browse the repository at this point in the history

  25. rearrange ComboBox params to make ktlint happy 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    aa78963 View commit details
    Browse the repository at this point in the history

  26. update API files 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2263fd6 View commit details
    Browse the repository at this point in the history

  27. fix single line on not-editable ComboBox 

    reference: #601 (review)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    208a0d9 View commit details
    Browse the repository at this point in the history

  28. prevent the ComboBox from expanding 

    reference: #601 (review)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6c767f8 View commit details
    Browse the repository at this point in the history

  29. iterate on colors 

    reference: #601 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8145218 View commit details
    Browse the repository at this point in the history

  30. address a couple of feedbacks 

    reference: #601 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    64f49e2 View commit details
    Browse the repository at this point in the history

  31. iterate on focus management on ComboBox 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5c2b019 View commit details
    Browse the repository at this point in the history

  32. reformat and update API files 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    07a1acd View commit details
    Browse the repository at this point in the history

  33. fix focus on click for not-editable ComboBox 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a113b86 View commit details
    Browse the repository at this point in the history

  34. inline a few variables to reduce clutter 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c95be74 View commit details
    Browse the repository at this point in the history

  35. add different states for different ComboBoxes 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    624a52c View commit details
    Browse the repository at this point in the history

  36. reformat things 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4661cd8 View commit details
    Browse the repository at this point in the history

  37. introduce ComboBoxStyle 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    07dd3f9 View commit details
    Browse the repository at this point in the history

  38. restore DropdownStyle 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6a02752 View commit details
    Browse the repository at this point in the history

  39. split ComboBoxes states in Standalone sample 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    71e8dbf View commit details
    Browse the repository at this point in the history

  40. tune old DropDown style for IDE 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a88e0b2 View commit details
    Browse the repository at this point in the history

  41. tune ComboBox focus once more 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    40defe8 View commit details
    Browse the repository at this point in the history

  42. update API files 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f7c3663 View commit details
    Browse the repository at this point in the history

  43. fix ComboBox popup expand 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2e4e928 View commit details
    Browse the repository at this point in the history

  44. remove focused padding for ComboBox divider 

    It's not happening in the IDE sample

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    fd5574a View commit details
    Browse the repository at this point in the history

  45. iterate on ComboBox focus 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d065855 View commit details
    Browse the repository at this point in the history

  46. iterate on ComboBox focus 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3badbd6 View commit details
    Browse the repository at this point in the history

  47. add ui-tests module 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    af08d89 View commit details
    Browse the repository at this point in the history

  48. start adding tests to ComboBox 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    606248a View commit details
    Browse the repository at this point in the history

  49. add more tests for ComboBox 

    Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
    @hamen
    hamen committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4506f01 View commit details
    Browse the repository at this point in the history