Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColorFilter to the IconActionButton API #641

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Oct 17, 2024

We did not do it before, and that's an oversight. This should also make things like #633 easier to do.

@rock3r rock3r added the api Changes related to the public API label Oct 17, 2024
@rock3r rock3r requested a review from hamen October 17, 2024 15:50
@rock3r rock3r self-assigned this Oct 17, 2024
@rock3r rock3r enabled auto-merge (squash) October 17, 2024 15:50
@rock3r rock3r disabled auto-merge October 17, 2024 15:52
@rock3r
Copy link
Collaborator Author

rock3r commented Oct 17, 2024

(please don't merge while I fix an oversight)

We did not do it before, and that's an oversight. This
should also make things like #633 easier to do.
@rock3r rock3r force-pushed the add-colorfilter-to-iconactionbutton branch from 9f18fc8 to b171c8a Compare October 17, 2024 16:18
@rock3r
Copy link
Collaborator Author

rock3r commented Oct 17, 2024

Added to the Selectable* and Toggleable* versions as well. Moved them to separate files because of the growth in size in the one file they were all in.

@rock3r rock3r enabled auto-merge (squash) October 17, 2024 16:19
@rock3r rock3r merged commit 3bb65e7 into main Oct 18, 2024
1 check passed
@rock3r rock3r deleted the add-colorfilter-to-iconactionbutton branch October 18, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Changes related to the public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants