Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please bundle LICENSE file to the published jar artifacts #472

Closed
vlsi opened this issue Nov 7, 2021 · 3 comments · Fixed by #490
Closed

Please bundle LICENSE file to the published jar artifacts #472

vlsi opened this issue Nov 7, 2021 · 3 comments · Fixed by #490
Assignees

Comments

@vlsi
Copy link

vlsi commented Nov 7, 2021

org.jetbrains.lets-plot:plot-config-portable-jvm:2.2.0 says it is MIT-licensed, however,

  1. It references an invalid license: https://opensource.org/licenses/MIT. The thing is there's no generic text for MIT license, and the actual uses of MIT always customize copyright owner and copyright year, so all "MIT licenses" are different.

  2. License text might vary over time (e.g. copyright owners might vary), so the ones who bundle MIT-licensed software need to carefully follow the exact license text for the particular version. For instance, if Apache JMeter bundles lets-plot, then MIT license requires that copyright notice shall be included in all copies or substantial portions of the Software. In other words, it requires to include the copy of the license with the appropriate copyright notice.

I would suggest including the license text as META-INF/LICENSE so the ones who consume (and redistribute) the jar know the license for the given artifact.

Here is the list of the artifacts without a corresponding license file:

  • org.jetbrains.lets-plot:lets-plot-kotlin-jvm:3.1.0
  • org.jetbrains.lets-plot:lets-plot-common:2.2.0
  • org.jetbrains.lets-plot:plot-config-portable-jvm:2.2.0
  • org.jetbrains.lets-plot:plot-builder-portable-jvm:2.2.0
  • org.jetbrains.lets-plot:plot-base-portable-jvm:2.2.0
  • org.jetbrains.lets-plot:plot-common-portable-jvm:2.2.0
  • org.jetbrains.lets-plot:vis-svg-portable-jvm:2.2.0
  • org.jetbrains.lets-plot:base-portable-jvm:2.2.0
@VDovidaytis-HORIS
Copy link
Collaborator

#490

@VDovidaytis-HORIS VDovidaytis-HORIS linked a pull request Dec 6, 2021 that will close this issue
@alshan
Copy link
Collaborator

alshan commented Dec 14, 2021

Hi @vlsi,
The LICENSE file is now added to all jars. Please, check out the latest lets-plot v2.2.1 and lets-plot-kotlin v3.1.1.

@vlsi
Copy link
Author

vlsi commented Dec 14, 2021

Thanks, 2.2.1 and 3.1.1 include the licenses indeed.

@vlsi vlsi closed this as completed Dec 14, 2021
vlsi added a commit to vlsi/jmeter that referenced this issue Dec 14, 2021
vlsi added a commit to vlsi/jmeter that referenced this issue Dec 14, 2021
vlsi added a commit to vlsi/jmeter that referenced this issue Dec 14, 2021
vlsi added a commit to vlsi/jmeter that referenced this issue Dec 25, 2021
vlsi added a commit to apache/jmeter that referenced this issue Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants