Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #123 fixing selection of xunit.exe based on installed framework… #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codekaizen
Copy link

Issue #123 fixing selection of xunit.exe based on installed framework version.

@NikolayPianikov
Copy link
Contributor

NikolayPianikov commented Aug 29, 2018

It is working solution but it requires maintenance for the cases when the content of the 'xunit.runner.console' nuget package is changed (I mean a list of supported frameworks) or Microsoft provides a new version of .net framework. For both cases we should update the script.

From my point of view it would be better to have the following logic:

  • by default we just get a sorted list of full .net frameworks from the directory like xunit.runner.console.xxx/tools/ filtered by pattern net4\d+ and choose the first item and use it as additional path to xunit.console.exe

  • for the case when it is important to run tests under the specific .net framework we could add a field like '.net framework' and use it:

    • as additional path to xunit.console.exe for the pattern net\d+

    • or as a path to dll in the command dotnet xunit.console.dll for the pattern netcoreapp.+ in the .net core case in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants