Added gitversion4 (beta) support as well as MR which sets TeamCity build counter as build number #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e latest 4.0 beta built (this probably will need to be changed in the future).
…ons json output and manually echo ##teamcity[setparameter messages back to stdout. This allows this runner to disable the built-in and not-configurable setting of build.number by GitVersion. The MR then outputs ##teamcity[buildnumer '<SemVer>+build%build.counter%'] to stdout which will set the build number in Teamcity to the SemVer + buildNN where nn is the build counter kept by Teamcity
|
Just an update on this, I made this MR so that the build metadata is passed as |
$semVer variable was not correctly escaped
Since v4 is released we don't need to pass --pre anymore
dampee
suggested changes
Apr 22, 2019
| } | ||
|
|
||
| Write-Host "##teamcity[progressMessage 'Running: $gitversion $safeArgs']" | ||
| $gvOutput = Invoke-Expression "gitversion $arguments" | Out-String |
There was a problem hiding this comment.
gitversion here should be $gitversion.
There was a problem hiding this comment.
You're right, thanks for noticing!
I've corrected it with another commit.
Previously gitversion was invoked reliant on it being in the PATH. This is now changed to the path constructed by the previous part of this script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing MR for GitVersion will set the
FullSemVervariable as build number in Teamcity, this variable is purely based on the repository and does not take into account the build counter kept by Teamcity.While in some situations (as described by @RobSmyth in GitTools/GitVersion#1367) this information is considered important or even critical.
At the moment Chocolately does not seem to offer a good way to say 'I want version 4.x, included beta- or pre-releases', so I've just had to pass the --pre parameter to the
choco installcall in these runners, this will result in the next beta release being installed (5.x?) as soon as GitVersion 4.0 is released in production.