SplFile{Info,Object} stub fixes #1651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,23 +235,29 @@ public function getRealPath(): string|false {} | |||
|
|
|||
| /** | |||
| * Gets an SplFileInfo object for the file | |||
| * | |||
| * @template T of SplFileInfo | |||
There was a problem hiding this comment.
Most of template in the stub have names, like
- TValue
- TDefault
- TKey
- TPriority
- ...
Maybe there is something better to do here than T.
| @@ -285,10 +302,12 @@ public function setFileClass(#[LanguageLevelTypeAware(['8.0' => 'string'], defau | |||
|
|
|||
| /** | |||
| * Sets the class used with getFileInfo and getPathInfo | |||
| * @template T of SplFileInfo* | |||
There was a problem hiding this comment.
Suggested change
| * @template T of SplFileInfo* | |
| * @template T of SplFileInfo |
no ?
I never saw a syntax with *
|
Pushed manually in 640e800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://youtrack.jetbrains.com/issue/WI-78159/SplFileInfoObject-stubs-are-missing-Exception-and-class-string-details