Fixes types on $unique on Gearman task methods #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the failing build process here is anything to do with my changes… |
donatj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the type for
$uniqueon a handful of task methods.This corrects them, as well as an incorrect link in the docs.
As you can see below, a small handful already had $unique as
string|nullbut the majority did not.phpstorm-stubs/gearman/gearman.php
Line 1510 in 5686f9c
phpstorm-stubs/gearman/gearman.php
Line 1542 in 5686f9c
phpstorm-stubs/gearman/gearman.php
Line 1555 in 5686f9c
https://github.com/donatj/phpstorm-stubs/blob/5686f9ceebde3d9338bea53b78d70ebde5fb5710/gearman/gearman.php#L1568-L1568