Add stubs for FrankenPHP #1669
Merged
Add stubs for FrankenPHP #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dunglas Don't worry about that failing test. Your changes looks correct so possibly it's an issue with test itself. I'll take a look at it. BTW adding extension name to |
|
@dunglas I apologize for the wrong comment. Actually your fix is absolutely correct and I just messed the failing test with another one. It seems today you know stubs tests better than me :) So I'll reopen PR and merge it. But it seems that the branch should be rebased on master again :( sorry for the extra work |
|
😅 No worries, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix https://github.com/JetBrains/phpstorm-stubs/actions/runs/10575852193/job/29300999760 (failure introduced in #1665).
I don't manage to run tests locally.