implemented TerminalShellCommandHandler #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a `TerminalShellCommandHandler` for the EFCore plugin to allow for executing EFCore commands from the terminal. Added new Kotlin class `EFCoreShellCommandHandler.kt` which contains the logic for matching and executing the given commands. The `matches()` method checks if the input command matches with the known EFCore commands. If the command is 'dotnet ef', it triggers a quick actions popup in the terminal. If the command matches another known EFCore command, the corresponding action is executed. Also updated the plugin's dependencies in `plugin.xml` and `build.gradle.kts` to include the terminal as a dependency for the EFCore plugin.
seclerp
requested changes
Sep 4, 2023
...m/jetbrains/rider/plugins/efcore/features/terminal/smartExecute/EFCoreShellCommandHandler.kt
Outdated
Show resolved
Hide resolved
...m/jetbrains/rider/plugins/efcore/features/terminal/smartExecute/EFCoreShellCommandHandler.kt
Outdated
Show resolved
Hide resolved
...m/jetbrains/rider/plugins/efcore/features/terminal/smartExecute/EFCoreShellCommandHandler.kt
Outdated
Show resolved
Hide resolved
...m/jetbrains/rider/plugins/efcore/features/terminal/smartExecute/EFCoreShellCommandHandler.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
Refactored EFCoreShellCommandHandler in the EFCore plugin to enhance the processing of entered shell commands. The string "dotnet ef" has been abstracted as a constant for better maintainability and consistency. Furthermore, the manner in which the command string is parsed and compared with known commands has been modified for more efficient execution.
seclerp
approved these changes
Sep 5, 2023
seclerp
added a commit
that referenced
this pull request
Sep 5, 2023
* Add command handling for shell terminal in EFCore plugin Implemented a `TerminalShellCommandHandler` for the EFCore plugin to allow for executing EFCore commands from the terminal. Added new Kotlin class `EFCoreShellCommandHandler.kt` which contains the logic for matching and executing the given commands. The `matches()` method checks if the input command matches with the known EFCore commands. If the command is 'dotnet ef', it triggers a quick actions popup in the terminal. If the command matches another known EFCore command, the corresponding action is executed. Also updated the plugin's dependencies in `plugin.xml` and `build.gradle.kts` to include the terminal as a dependency for the EFCore plugin. * from function to companion object Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com> * Refactor EFCoreShellCommandHandler for better command parsing Refactored EFCoreShellCommandHandler in the EFCore plugin to enhance the processing of entered shell commands. The string "dotnet ef" has been abstracted as a constant for better maintainability and consistency. Furthermore, the manner in which the command string is parsed and compared with known commands has been modified for more efficient execution. --------- Co-authored-by: Alessio De Vito <alessio.devito@jetbrains.com> Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented #155