RG-2525 feat(DropdownMenu): accept children #8039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
requested changes
Dec 16, 2024
andrey-skl
approved these changes
Dec 16, 2024
so it makes it possible to access popupProps and call methods from it, e.g. onCloseAttempt
skoch13
force-pushed
the
sk/accept-children-by-dropdown-menu
branch
from
a1bb3ae to
8f5d6e0
Compare
Hypnosphi
reviewed
Dec 16, 2024
| @@ -67,23 +72,52 @@ function DropdownAnchorWrapper({ | |||
| return <div {...anchorAriaProps}>{anchor}</div>; | |||
| } | |||
|
|
|||
| function renderDropdownMenuChildren<T>({children, popupMenuProps}: DropdownMenuChildren<T>) { | |||
| const {data, ...restPopupMenuProps} = popupMenuProps; | |||
There was a problem hiding this comment.
otherwise we overwrite data provided to PopupMenu. Do you suggest excluding data from props on a consumer's level?
There was a problem hiding this comment.
If user provides data directly to DropdownMenu we shouldn't just ignore it.
we overwrite data provided to PopupMenu
We don't overwrite anything if children is a function. If it's a React element, you can prevent cloneElement resetting data to undefined by checking that it's not undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it makes it possible to access
popupPropsand call methods from it, e.g.onCloseAttempt.Case: when one renders
DropdownMenuinside of aDropdownMenuand wants to close the parentDropdownMenuon the children's select. Otherwise consumer have to stop event propagation on the wrapper level, and create hackish solutions such asDropdownMenukey re-generation ononSelectcalls. Example in story.