Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make uninstall #78

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Fix make uninstall #78

merged 2 commits into from
Jun 11, 2024

Conversation

tuurep
Copy link
Contributor

@tuurep tuurep commented Apr 3, 2024

Hey, turns out I found some issues in the Makefile, and the fix seems perfect 😄

Please make sure for example that /usr/lib/web-greeter/ is removed as intended and in the right place.

Plus added a small correction for \ns being literal in make uninstall_preserve output as follows:

 Themes are not uninstalled. Remove them manually or use `make uninstall_all`:	\n/usr/share/web-greeter
 web-greeter config was not uninstalled. Remove it manually or use `make uninstall_all`:	\n/etc/lightdm/web-greeter.yml

This PR should especially make it easier to switch between a manual build and building with AUR.

"${DESTDIR_PREFIX}/web-greeter/" expands as "/usr/web-greeter"
    * put /usr/share/web-greeter under `uninstall_all` because that's
      where themes are
    * put /usr/lib/web-greeter under `uninstall_preserve` based on the
      comment: "Uninstall everything except themes and web-greeter.yml"

Removing lightdm-wrapper turned out to be a typo: `.` instead of `-` at
one point.

App icon removal missing.
@JezerM
Copy link
Owner

JezerM commented Jun 11, 2024

LGTM, thanks! Sorry for the late response

@JezerM JezerM merged commit d165f9c into JezerM:master Jun 11, 2024
2 checks passed
@tuurep
Copy link
Contributor Author

tuurep commented Jun 12, 2024

It's okay 😄 Thanks for merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants