Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onChange method not called when char count == maxCharCount #255

Closed
cwhitwell opened this issue Mar 17, 2020 · 1 comment
Closed

onChange method not called when char count == maxCharCount #255

cwhitwell opened this issue Mar 17, 2020 · 1 comment
Labels
Milestone

Comments

@cwhitwell
Copy link

Hi there,
I've been running some tests on the SunEditor as I will be using it in my web application. First of all big props as it works really well :). I have however found some bugs and will raise a separate issue for each.

So this bug is when you are typing values into the editor I can see the 'onChange' event being called each time there is a change, as expected. However when you type the final character (to reach the maxCharCount limit) the event is not called. This could cause problems as I am saving the data via the 'onChange' event, which means with a limit of 100 chars for example, I could only ever save 99 chars and not the final 100.

Environment:
MacOS Mojave V10.14
Google Chrome Version 80.0.3987.132 (Official Build) (64-bit)
suneditor V2.26.0

Please see video demo attached (I've added a console.log in the onChange method).
onChange Bug SunEditor.mov.zip

@JiHong88 JiHong88 added the bug label Mar 17, 2020
@JiHong88 JiHong88 added this to the 2.27.0 milestone Mar 17, 2020
JiHong88 added a commit that referenced this issue Mar 18, 2020
fix: #256 holding key
modify: #258 submenuOff when keydown
@JiHong88
Copy link
Owner

The 2.27.0 version has been updated.
If there is an issue, please register as a new issue.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants