Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary counter. #281

Closed
shaan1974 opened this issue Mar 22, 2020 · 3 comments
Closed

Binary counter. #281

shaan1974 opened this issue Mar 22, 2020 · 3 comments
Labels
enhancement
Milestone
2.28.1

Comments

@shaan1974
Copy link

Hello,

I'v test the binary counter feature.
It's seems that the binary counter don't take in count the html tags only the text content.

Have a nice day
Shaan1974
@JiHong88
Copy link
Owner

JiHong88 commented Mar 22, 2020 •
edited
Loading

Yeah, That is the intended behavior.
I will add an option.
"charCounterType" : "char", "byte", "byte-html" (getByteLength(wysiwyg.innerHTML))

@shaan1974
Copy link
Author

Ok thanks.

@JiHong88 JiHong88 added this to the 2.29.0 milestone Mar 23, 2020
@JiHong88 JiHong88 modified the milestones: 2.29.0, 2.28.1 Mar 23, 2020
JiHong88 added a commit that referenced this issue Mar 30, 2020
@JiHong88
#281 , #285
2a18f1e 
add: option-charCounterType-byte-html, functions-getCharCount
fix: submenu - left location
hotfix: Component deletion bug
@JiHong88 JiHong88 closed this as completed Apr 1, 2020
@JiHong88
Copy link
Owner

JiHong88 commented Apr 2, 2020

The 2.28.1 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.28.1
Development

No branches or pull requests
2 participants
@shaan1974 @JiHong88