Fix tabbing #370
Merged
Fix tabbing #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the new tabDisable option has usability problems: * In classical mode a `tab` focuses on the toolbar of the next editor, while we want to go to the edit area of the next editor * In inline mode, this problem doesn't exist (because the toolbars are not displayed) but `shift-tab` doesn't work (the focus may be in the hidden toolbar) So here is a proposed solution by setting tabindex="-1" cf. https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex Maybe it's not the right way to fix the problem, but it gives you a hint of what it could be.
|
Hi, @madarche |
|
@JiHong88 you're most welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the new tabDisable option has usability problems:
tabfocuses on the toolbar of the next editor, while we want to go to the edit area of the next editorshift-tabdoesn't work (the focus may be in the hidden toolbar)So here is a proposed solution by setting tabindex="-1" cf. https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex
Maybe it's not the right way to fix the problem, but it gives you a hint of what it could be.