Hebrew translation #620
Merged
Hebrew translation #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-programming
commented
Feb 2, 2021
src/lang/he.js
Outdated
| mathBox: { | ||
| title: 'נוסחה', | ||
| inputLabel: 'סימנים מתמטים', | ||
| fontSizeLabel: 'גודל דופן', |
There was a problem hiding this comment.
fontSizeLabel should be
גודל גופן
it was a typo
tom-programming
commented
Feb 2, 2021
src/lang/he.js
Outdated
| tag_h: 'כותרת', | ||
| tag_blockquote: 'ציטוט', | ||
| tag_pre: 'קוד', | ||
| template: 'תבניט', |
There was a problem hiding this comment.
template should be
תבנית
sorry, another typo
|
I reviewed my own work and found two typos. I used the comment feature because I am not familiar with post-PR corrections. Sorry for the errors |
|
@tom-programming Thank you for your contribution.!! |
|
The 2.36.2 version has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Your work is amazing. It's the only HTML/Javascript editor where it is really easy to add tables. I now also added a Hebrew translation. However Hebrew is RTL and it would be good to have a language-related flag that sets the default text direction for a language.