#847 remove video controls attr by default

[zt1983811]

Context:

• As discussed with @SystemChanger in issue Video attribute controls always true, how can it be removed #847 , we decide to make this PR to remove controls=true default attribute added by video editor.
• The problem was when using HTML code editor and remove controls=true attribute, it added it back when switch to text editor.

Change:

• removed element.setAttribute('controls', true) in video.js function _setTagAttrs like that controls=true will stop auto append

Example

• Before:
  

• After
  

[JiHong88]

@zt1983811 This commit will always remove the control properties, even when pasting, etc.
I'll add an video control option to the next version.

[zt1983811]

@JiHong88 I tested it and it doesn't really remove it if you add it through HTML code editor. I can make a button in add video popup to add it or remove it if you want?

[SystemChanger]

@zt1983811 It looks like JiHong is talking about pasting via "ctrl+v".
@JiHong88 How could we reproduce this? Maybe from other editors?
I have tested copying the video from this editor: https://html-online.com/editor/ and the video was copied with "controls" tags from the source, which is correct behavior (isn't it?).
Copying the video from one suneditor instance to another works the same.
Adding the video with a "video" button from url works correctly too (it inserts as iframe)

Also, I found that we have some issues not related to our current problem:

1. Problem with copying videos that was added via code-view mode from one suneditor instance to another.
   
2. Videos are not added from the file system (just nothing happens) (option for it is enabled, you can check it on npm run dev).
   OS: Windows 10
   Browser: Google Chrome
   Version: latest

[JiHong88]

The 2.42.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.