Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of react for screenreaders #220

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

WLYau
Copy link
Contributor

@WLYau WLYau commented Mar 19, 2024

This is to fix how the parsed content is rendered on the page so that the screen reader reads it out properly, at the moment, it's reading the content out as if there's no space, this will fix that.

Here's what it was rendering before from the result of react SSR

Screenshot 2024-03-19 at 10 16 23

Here's after the fix

Screenshot 2024-03-19 at 10 17 33

Copy link

changeset-bot bot commented Mar 19, 2024

⚠️ No Changeset found

Latest commit: b18810b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@WLYau WLYau closed this Mar 19, 2024
Co-authored-by: WAI YAU <waister@ip-192-168-1-52.eu-west-1.compute.internal>
@JiLiZART
Copy link
Owner

Thanks for contribution! I will take a look later.

@JiLiZART
Copy link
Owner

Looks good. Need to sync latest with latest master with fixed pipeline

@JiLiZART
Copy link
Owner

👍

@JiLiZART JiLiZART merged commit e875c78 into JiLiZART:master Mar 27, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen reader reads React rendered content as if there's no space between the words.
3 participants