Fix test_wr_arp not stable issue #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Sometimes test_wr_arp will fail when config reload or restart system action is in previous tests. Because BGP route advertising is not completed after that action, in test_wr_arp we can not get the desired result by "ip route show type unicast". Therefore, adding retry to get ip route will make this test more stable.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Make test_wr_arp more stable
How did you do it?
Use wait_until to retry getting ip route
How did you verify/test it?
Do config reload, before the bgp route advertise is completed run this test.
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
t0
Documentation